[openstreetmap/openstreetmap-website] Move continue auth/start mapping button to appear fixed to the bottom of the welcome page (PR #4947)

[Emin Kocan]

@kcne commented on this pull request.



>  <div class='alert alert-primary'>
   <h2><%= t ".add_a_note.title" %></h2>
   <p><%= t ".add_a_note.para_1" %></p>
   <p><%= t ".add_a_note.para_2_html", :map_link => link_to(t(".add_a_note.the_map"), root_path),
                                       :note_icon => tag.span(:class => "icon note bg-dark rounded-1") %></p>
 </div>
+
+<% content_for :footer_outer_class, "sticky-bottom" %>
+<% content_for :footer do %>
+  <div class='d-flex justify-content-center align-items-center'>
+    <% if params[:oauth_return_url] %>
+      <a class="btn btn-primary d-block d-sm-inline-block" href="<%= params[:oauth_return_url] %>"><%= t ".continue_authorization" %></a>

To be honest, this PR was from a while ago, and I don't remember exactly why I added it. I must have encountered some layout issues at the time. However, I've now removed it locally, and everything looks fine on both small and large screens, so I'll just go ahead and remove it since it seems unnecessary.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4947#discussion_r1888561336
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4947/review/2508953470 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241217/ef947964/attachment-0001.htm>