[openstreetmap/openstreetmap-website] Add social sharing functionality (PR #4985)

Tom Hughes notifications at github.com
Wed Dec 18 14:01:16 UTC 2024


@tomhughes commented on this pull request.



> @@ -75,4 +76,32 @@ def render_flash(flash)
   rescue StandardError
     flash.inspect if Rails.env.development?
   end
+
+  # Generates a set of social share buttons based on the specified options.
+  def render_social_share_buttons(opts = {})
+    sites = opts.fetch(:allow_sites, [])

What is the purpose of the `allow_sites` option and the supporting logic that allows filtering? As far as I can tell it's tested but never actually used by any other code?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4985#pullrequestreview-2511921655
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4985/review/2511921655 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241218/043f8cff/attachment.htm>


More information about the rails-dev mailing list