[openstreetmap/openstreetmap-website] Refactor render_social_share_buttons helper (Issue #5415)
Anton Khorev
notifications at github.com
Wed Dec 18 17:22:59 UTC 2024
We have enough unused code in helpers. For example `auth_button` has `options` argument. Options for what? For link or image? Turns out it's for path. But it's never used. `user_image_url` also has `options`, also unused, and if you passed it, it would be used only in one branch. However all of that is insignificant compared to *classic pagination* #5205.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5415#issuecomment-2551885212
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/issues/5415/2551885212 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241218/a1b6d809/attachment.htm>
More information about the rails-dev
mailing list