[openstreetmap/openstreetmap-website] Modify the way "Friends" are added (PR #5261)

David Tsiklauri notifications at github.com
Tue Dec 24 09:22:13 UTC 2024


@nertc commented on this pull request.



> @@ -280,8 +280,10 @@
   resource :profile, :only => [:edit, :update]
 
   # friendships
-  match "/user/:display_name/make_friend" => "friendships#make_friend", :via => [:get, :post], :as => "make_friend"
-  match "/user/:display_name/remove_friend" => "friendships#remove_friend", :via => [:get, :post], :as => "remove_friend"
+  scope "/user/:display_name" do
+    resource :follow, :only => [:create, :destroy], :path => "follow"
+  end
+  get "/user/:display_name/follow" => "follows#index"

I agree with you. Changed `GET /follow` to `GET /follow/edit`. It's much intuitive and consistent.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5261#discussion_r1896582646
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5261/review/2521720808 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241224/0305063d/attachment.htm>


More information about the rails-dev mailing list