[openstreetmap/openstreetmap-website] New note marker variable (PR #5443)

[Anton Khorev]

If
- you open `/note/new` while your zoom is too low as described in #1291 
- you zoom out far enough while on `/note/new`,

show a warning message and disable the submit button.

![image](https://github.com/user-attachments/assets/abb8e7d1-316b-411c-94fb-614b87355330)

Fixes #1291 and another bug: note marker was disappearing together with notes layer when visible area became too large.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5443

-- Commit Summary --

  * Rename newNote to newNoteMarker
  * Don't pass marker to createNote()
  * Rename updateMarker() to addCreatedNoteMarker()
  * Remove unused return value of addCreatedNoteMarker()
  * Add new note marker to root map layer instead of noteLayer
  * Move new note page.pushstate/popstate next to page.load
  * Convert newHalo() to addHal() and removeHalo()
  * Add addNewNoteMarker() and removeNewNoteMarker() functions
  * Call removeNewNoteMarker() only from page.unload()
  * Remove active class from addNoteButton only in page.unload()
  * Let page.load proceed when zoomed out, disabling submit
  * Decrease new note marker opacity when zoomed out
  * Move new note marker to click location

-- File Changes --

    M app/assets/javascripts/index/new_note.js (143)
    M app/assets/javascripts/leaflet.note.js (13)
    M app/views/notes/new.html.erb (1)
    M test/system/create_note_test.rb (21)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5443.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5443.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5443
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5443 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241225/fdf68238/attachment.htm>