[openstreetmap/openstreetmap-website] Add social profile links (PR #5439)

Anton Khorev notifications at github.com
Fri Dec 27 00:45:30 UTC 2024


@AntonKhorev commented on this pull request.



> @@ -40,6 +40,21 @@
     </div>
   </fieldset>
 
+  <fieldset class="mb-3">
+    <legend><%= t ".social_links.legend" %></legend>
+    <div id="social_links">
+      <%= f.fields_for :social_links do |social_link_form| %>
+        <div class="social-link-fields row mb-3">
+          <%= social_link_form.text_field :url, :hide_label => true, :wrapper_class => "col-sm-8" %>
+          <%= social_link_form.check_box :_destroy, :wrapper_class => "d-none social_link_destroy" %>
+          <%= social_link_form.label :_destroy, t(".social_links.remove"), :class => "btn btn-outline-primary col-sm-1 align-self-start" %>
+        </div>
+      <% end %>
+    </div>
+
+    <%= link_to "+", "#", :id => "add-social-link", :class => "btn btn-outline-primary" %>

Why is it a link and not a button?

Why adding is "+" but removing is "Remove"?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#pullrequestreview-2523556899
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5439/review/2523556899 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241226/4434c8ee/attachment.htm>


More information about the rails-dev mailing list