[openstreetmap/openstreetmap-website] Make preferences page editable without clicking 'Edit Preferences' (PR #5449)

[Anton Khorev]

When you select *My Preferences* from the user dropdown, you get to `/preferences`, which is a page that shows you your preferences but doesn't let you edit them. If you want to edit, you'll have to make one extra click on the *Edit Preferences* button. See https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2563164175 for some click count considerations.

The question is why do you need the uneditable preferences page. It was added in https://github.com/openstreetmap/openstreetmap-website/commit/2403630da87df8a3b57913e8949ae0ff8f611d22. The reasoning according to #3167 was to split the settings form. But that doesn't explain why the uneditable page was added. When you click *My Settings*, you get to an editable page. When you click *My Preferences*, you don't. If you don't want to edit your preferences, can you just view them on the editable page? I think you can. Why don't we make *My Preferences* always editable?
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5449

-- Commit Summary --

  * Make preferences page editable without clicking 'Edit Preferences'

-- File Changes --

    M app/controllers/preferences_controller.rb (4)
    D app/views/preferences/edit.html.erb (28)
    M app/views/preferences/show.html.erb (48)
    M config/locales/en.yml (4)
    M config/routes.rb (3)
    M test/controllers/preferences_controller_test.rb (25)
    M test/system/preferences_test.rb (4)
    M test/system/view_communities_test.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5449.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5449.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5449
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5449 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241229/cce739c2/attachment.htm>