[openstreetmap/openstreetmap-website] Make preferences page editable without clicking 'Edit Preferences' (PR #5449)

[Star ⭐ Mobile Repair - Al Khobar]

> When you select *My Preferences* from the user dropdown, you get to `/preferences`, which is a page that shows you your preferences but doesn't let you edit them. If you want to edit, you'll have to make one extra click on the *Edit Preferences* button. See https://github.com/openstreetmap/openstreetmap-website/issues/5324#issuecomment-2563164175 for some click count considerations.
> 
> The question is why do you need the uneditable preferences page. It was added in https://github.com/openstreetmap/openstreetmap-website/commit/2403630da87df8a3b57913e8949ae0ff8f611d22. The reasoning according to #3167 was to split the settings form. But that doesn't explain why the uneditable page was added. When you click *My Settings*, you get to an editable page. When you click *My Preferences*, you don't. If you don't want to edit your preferences, can you just view them on the editable page? I think you can. Why don't we make *My Preferences* always editable?



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5449#issuecomment-2564856357
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5449/c2564856357 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241229/a9aefa40/attachment-0001.htm>