[openstreetmap/openstreetmap-website] New note page on low zooms (PR #5443)
Anton Khorev
notifications at github.com
Tue Dec 31 22:51:46 UTC 2024
@AntonKhorev commented on this pull request.
> @@ -35,11 +35,13 @@ OSM.NewNote = function (map) {
OSM.router.route("/note/new");
});
- function createNote(marker, form, url) {
- var location = marker.getLatLng().wrap();
+ function createNote(form, url) {
+ if (!newNoteMarker) return;
Made some changes to be sure that:
- `addNewNoteMarker` is called from `page.load`
- `removeNewNoteMarker` is called only from `page.unload`
- `createNote` doesn't access the marker
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5443#discussion_r1900286624
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5443/review/2526729160 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241231/c2cf2945/attachment.htm>
More information about the rails-dev
mailing list