[openstreetmap/openstreetmap-website] New note page on low zooms (PR #5443)

Anton Khorev notifications at github.com
Tue Dec 31 23:18:38 UTC 2024


@AntonKhorev commented on this pull request.



> @@ -130,11 +127,14 @@ OSM.NewNote = function (map) {
     });
 
     newNoteMarker.on("dragstart dragend", function (a) {
-      newHalo(newNoteMarker.getLatLng(), a.type);
+      removeHalo();
+      if (a.type !== "dragstart") {

halo is supposed to reappear on drag end, so I guess it makes more sense to check for `dragend`. Updated.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5443#discussion_r1900290379
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5443/review/2526733761 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241231/7d6cc592/attachment.htm>


More information about the rails-dev mailing list