[openstreetmap/openstreetmap-website] Re-arrange login and signup screens as discussed in #4128 (PR #4455)

[Andy Allan]

@gravitystorm requested changes on this pull request.

I've added a couple of design comments that stand out to me, but there's plenty more here for me to review later.

> @@ -1086,4 +1086,102 @@ div.secondary-actions {
   }
 }
 
+.auth-container {

I haven't had the chance for a full review, but these stylesheet changes stand out to me. Our general approach is to use the bootstrap framework, not custom CSS. In particular, custom max-widths, custom font sizes, custom border radii etc aren't the way we should be implementing changes.

Instead, bootstrap classes should be added to html elements, e.g. `rounded-2` should be used. These can of course be used sparingly, since html elements like `<small>` should do the right thing too.

I can see an implementation of tabs here too, and I would expect instead to see bootstrap tabs being used, as elsewhere on the site.

>  <% end %>
 
-<% content_for :heading_class, "pb-0" %>
-<% content_for :heading do %>
-  <div class='header-illustration new-user-main'>

I'm surprised to see the header-illustration being removed from the signup pages, since it's one of the few pieces of genuinely original design in our project! But it's more surprising to see it removed from just this page, and not from the other pages that share the same design.

What's the design rationale, if any, behind removing it?

We don't have much in-house capacity for this kind of design, so it concerns me that whenever external companies come in, they often focus on these few pages (login signup etc) and keep redesigning over the top of whoever made the last external design changes. This leads to no redesign being anywhere near comprehensive, and each redesign not quite covering the same (small) ground as the previous one, and we end up with widespread inconsistencies.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4455#pullrequestreview-1856038628
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4455/review/1856038628 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240201/c28473c9/attachment-0001.htm>