[openstreetmap/openstreetmap-website] Note: Add body & author (PR #4481)

[Gregory Igelmund]

A summary of the recent changes:

- 1c3d3b6 redacts `Note#body` if `Note#author` is soft-deleted
- edfab03 extracted Note-Migration code into `Note::MigrateOpenedComment` and added basic tests for that class
- 5f4a414 hides the authors display name in `api/notes/_note.rss.builder` if the author is deleted (the same way the author name is hidden in the Web UI)

@gravitystorm could you give this PR a rough review so we can spot weak spots or issues I can address?

@tomhughes thanks for trying out the `UPDATE`-SQL Statement.
I'd be interested if there are any `NoteComment`-records with `event: "opened"` and with a `body` either being `NULL` or `EMPTY`.
The migration code assumes that there will be a non-zero-length `body` but there are neither DB constraints nor Model Validations enforcing this.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4481#issuecomment-1932283483
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4481/c1932283483 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240207/69e11730/attachment.htm>