[openstreetmap/openstreetmap-website] Remove html type from changeset feed entry titles (PR #4522)

[Anton Khorev]

Look at https://github.com/openstreetmap/openstreetmap-website/commit/fc9768f34c803f9a9746d1705af097655d55f3e2. It added `type="html"` to changeset feed entries for the reasons stated in the commit message. But is it actually correct? Let's check.

I created a couple of changesets. This is how their comments are shown on the `/history` page. I expect to see the same in a feed reader.

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/13398e89-74d7-441a-8583-3b0c45a3b968)

This is how their titles look in `/history/feed` output. They are always escaped once.

    <title type="html">Changeset 58 - is it going to &lt;em&gt;emphasize&lt;/em&gt;?</title>
    ...
    <title type="html">Changeset 57 - this is unescaped (&lt;); this is escaped (&amp;lt;)</title>

This is how they look in [Liferea](https://en.wikipedia.org/wiki/Liferea). Not what's expected.

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/abf9d80f-1e57-4254-9d6c-bc5391f0e48a)

This is how they look after `type="html"` is removed.

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/8999b9f3-7047-4e3e-b906-e1ba0aafd0af)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4522

-- Commit Summary --

  * Remove html type from changeset feed entry titles

-- File Changes --

    M app/views/changesets/index.atom.builder (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4522.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4522.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4522
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4522 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240214/7e7b6898/attachment.htm>