[openstreetmap/openstreetmap-website] Convert note pagination to newer/older note pages (PR #4532)

[Anton Khorev]

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/b6e20755-df9c-41b1-8126-556309c726ef)

A bit more work is required here because the order is unstable. It could be changed by any incoming note comment, causing before/after links to behave unexpectedly. I need to add dates to those links and use dates as fallbacks if that note was updated.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4532

-- Commit Summary --

  * Convert note pagination to newer/older note pages
  * Check note list contents in unpaged note tests
  * Shorten path calls in notes controller tests
  * Redirect to first page of notes if before/after id is invalid

-- File Changes --

    M app/controllers/notes_controller.rb (34)
    D app/views/notes/_notes_paging_nav.html.erb (17)
    M app/views/notes/index.html.erb (12)
    M config/locales/en.yml (7)
    M test/controllers/notes_controller_test.rb (103)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4532.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4532.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4532
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4532 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240222/8bb9391d/attachment.htm>