[openstreetmap/openstreetmap-website] Show unredacted element history to moderators (PR #4324)

Tom Hughes notifications at github.com
Sun Feb 25 14:37:07 UTC 2024


@tomhughes commented on this pull request.

All looks good really, just one very minor suggestion.

> @@ -77,4 +78,10 @@ def changeset
   end
 
   def query; end
+
+  private
+
+  def require_moderator_for_unredacted_history
+    deny_access(nil) if params[:show_redactions] && !current_user&.moderator?

I actually made `nil` the default for `deny_access` earlier today so if you rebase on master you can get rid of the argument here now.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4324#pullrequestreview-1899690788
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4324/review/1899690788 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240225/7d0541d3/attachment.htm>


More information about the rails-dev mailing list