[openstreetmap/openstreetmap-website] Move changeset show action to changesets controller (PR #4552)

Anton Khorev notifications at github.com
Thu Feb 29 10:10:53 UTC 2024


Moves all changeset-related code out of browse controller.

This is already true on the javascript side with [history.js](https://github.com/openstreetmap/openstreetmap-website/blob/master/app/assets/javascripts/index/history.js) and [changeset.js](https://github.com/openstreetmap/openstreetmap-website/blob/master/app/assets/javascripts/index/changeset.js) separate from [browse.js](https://github.com/openstreetmap/openstreetmap-website/blob/master/app/assets/javascripts/index/browse.js).
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4552

-- Commit Summary --

  * Move changeset show action to changesets controller
  * Move changeset element headings to changesets locale
  * Move all browse.changeset strings to changesets locale
  * Move changeset created/closed popup/feed strings to changesets locale
  * Move changeset created/closed time ago strings to changesets locale

-- File Changes --

    M app/abilities/ability.rb (5)
    M app/controllers/browse_controller.rb (19)
    M app/controllers/changesets_controller.rb (23)
    M app/helpers/browse_helper.rb (4)
    M app/helpers/changesets_helper.rb (8)
    R app/views/changesets/_paging_nav.html.erb (0)
    M app/views/changesets/index.atom.builder (6)
    R app/views/changesets/show.html.erb (2)
    M config/locales/en.yml (47)
    M config/routes.rb (2)
    M test/controllers/browse_controller_test.rb (85)
    M test/controllers/changesets_controller_test.rb (70)
    M test/test_helper.rb (36)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4552.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4552.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4552
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4552 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240229/8799070a/attachment.htm>


More information about the rails-dev mailing list