[openstreetmap/openstreetmap-website] Support linking to object versions (PR #4468)

Anton Khorev notifications at github.com
Fri Jan 12 11:18:38 UTC 2024


> How about https://www.openstreetmap.org/about#open-data, is that exposed or used for styling?

You can always find ids that are not used for styling and try to link to them. Something like this requires ids:

```html
<label for="input_id" ... > ... </label>
<input id="input_id" ... >
```

However there are some ids that are used for linking, despite not having visible links. One of them is changeset comment ids `c123456`. That's similar to what's being added here. Therefore it's potentially going to have the same problems if pagination is added to changeset discussion: a changeset page is loaded, but it doesn't have the comment you're trying to link to because it's on another page. Actually this is fixable with some javascript, but you'll have to convince the maintainers to add that javascript.

But all of those problems are less likely for changeset comments because changesets very rarely have a ton of comments. Relations with hundreds of versions however exist and so are requests to add pagination for them like https://github.com/openstreetmap/openstreetmap-website/issues/3524.

Here's a pull request adding visible links to changeset comments: https://github.com/openstreetmap/openstreetmap-website/pull/4134.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4468#issuecomment-1888911768
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4468/c1888911768 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240112/5f7150da/attachment.htm>


More information about the rails-dev mailing list