[openstreetmap/openstreetmap-website] Element version pages (PR #4480)

Anton Khorev notifications at github.com
Tue Jan 16 02:13:34 UTC 2024


Basic support for https://github.com/openstreetmap/openstreetmap-website/issues/662. Doesn't try to show the old versions on the map, doesn't have all the links for navigation between versions and data downloads.

The paths scheme is `/node/123/history/4` in order to be able to point the index routes of old element controllers to `/node/123/history`.

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/7022d8e2-3a52-4f05-ae96-4393b827e467)

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/83116d7a-4cf0-49cf-bc80-364c56cf8a54)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4480

-- Commit Summary --

  * Add node version pages
  * Add way version pages
  * Add relation version pages
  * Add links to element versions from version headings

-- File Changes --

    M app/abilities/ability.rb (3)
    M app/assets/javascripts/index.js (14)
    A app/controllers/old_nodes_controller.rb (19)
    A app/controllers/old_relations_controller.rb (19)
    A app/controllers/old_ways_controller.rb (19)
    M app/views/browse/_common_details.html.erb (6)
    M app/views/browse/_node.html.erb (6)
    M app/views/browse/_relation.html.erb (4)
    M app/views/browse/_relation_member.html.erb (2)
    M app/views/browse/_tag_details.html.erb (2)
    M app/views/browse/_way.html.erb (6)
    A app/views/old_nodes/not_found.html.erb (7)
    A app/views/old_nodes/show.html.erb (5)
    A app/views/old_relations/not_found.html.erb (7)
    A app/views/old_relations/show.html.erb (5)
    A app/views/old_ways/not_found.html.erb (7)
    A app/views/old_ways/show.html.erb (5)
    M config/locales/en.yml (9)
    M config/routes.rb (3)
    M test/controllers/browse_controller_test.rb (38)
    A test/controllers/old_nodes_controller_test.rb (26)
    A test/controllers/old_relations_controller_test.rb (35)
    A test/controllers/old_ways_controller_test.rb (40)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4480.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4480.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4480
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4480 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240115/5c799d32/attachment-0001.htm>


More information about the rails-dev mailing list