[openstreetmap/openstreetmap-website] Show blocked api response when interacting with notes (PR #4462)

Anton Khorev notifications at github.com
Tue Jan 16 22:46:42 UTC 2024


@AntonKhorev commented on this pull request.



> @@ -52,20 +52,17 @@ OSM.Note = function (map) {
           OSM.loadSidebarContent(path, function () {
             initialize(path, id, moveToNote);
           });
+        },
+        error: function (xhr) {
+          $(form).find("#comment-error").text(xhr.responseText);
+          $(form).find("#comment-error").prop("hidden", false);

I was copying the calls from changeset.js where they are not chained:

https://github.com/openstreetmap/openstreetmap-website/blob/98f8bbace3bec93a23fd9924f0a02c9d41c9cf69/app/assets/javascripts/index/changeset.js#L50-L51

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4462#discussion_r1454162726
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4462/review/1825520850 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240116/37773c95/attachment.htm>


More information about the rails-dev mailing list