[openstreetmap/openstreetmap-website] Click login below inputs in system test sign in (PR #4489)

[Anton Khorev]

Currently logins in system tests work by going to the login page, filling in the username and password and clicking the first "Login" thing. You hope that this first "Login" thing is the login button of the login form, which it currently is. But if you change the website navigation, it may no longer be. #4455 makes such change, adding a "Login" tab above the form. Then it adds workarounds [1](https://github.com/openstreetmap/openstreetmap-website/pull/4455/files#diff-29beaabe278fd17493296745cecb67919f0906b47b8246ab770f5517615d9ef7R203-R205) [2](https://github.com/openstreetmap/openstreetmap-website/pull/4455/files#diff-ba37813ca277c227a74a372479b7b05b7f3ff085d890ab708f80d62573efdb7aR248).

How about we click the button below the inputs instead?
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4489

-- Commit Summary --

  * Click login below inputs in system test sign in

-- File Changes --

    M test/test_helper.rb (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4489.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4489.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4489
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4489 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240119/ad760ca6/attachment.htm>