[openstreetmap/openstreetmap-website] Refactor login form to use form helpers for password field (PR #4935)

Emin Kocan notifications at github.com
Mon Jul 1 12:08:32 UTC 2024


This PR addresses issue #4773: "Raw HTML input used for password field." The login form previously used raw HTML for the password input field, which bypassed the automatic HTML attribute generation and site-wide overrides provided by form helpers.

- Replaced the raw HTML input for the password field with the f.password_field helper.
- Ensured the alignment of the password label and the "forgot password" link using Bootstrap classes.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4935

-- Commit Summary --

  * refactor password to use form attributes instead of raw html

-- File Changes --

    M app/views/sessions/new.html.erb (16)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4935.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4935.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4935
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4935 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240701/bc7891ab/attachment.htm>


More information about the rails-dev mailing list