[openstreetmap/openstreetmap-website] Refactor login form to use form helpers for password field (PR #4935)

[Tom Hughes]

@tomhughes requested changes on this pull request.



> @@ -33,15 +33,12 @@
 
     <%= f.text_field :username, :label => t(".email or username"), :autofocus => true, :tabindex => 1, :value => params[:username] %>
 
-    <div class="row">
-      <div class="col">
-        <%= f.label :password, t(".password"), :class => "form-label" %>
-      </div>
-      <div class="col text-end">
-        <small><%= link_to(t(".lost password link"), user_forgot_password_path) %></small>
-      </div>
+    <div class="col d-flex justify-content-between align-items-center">
+      <%= f.label :password, t(".password"), :class => "my-1" %>

I think that class wants to be `my-2` to make the whole row the same height as before, and as the label for the username - as it is the label for password is closer to the field than the label for username is.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4935#pullrequestreview-2151989600
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4935/review/2151989600 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240701/24d22bd2/attachment.htm>