[openstreetmap/openstreetmap-website] Share button unusable on a cell phone (PR #4949)

David Tsiklauri notifications at github.com
Thu Jul 4 13:45:26 UTC 2024


This PR addresses "Share button unusable on a cell phone" issue mentioned in the #3988 

Added class to track if "Share", "Layer" and "Map Key" buttons have been clicked. Fixes #3988  

Change affects "Share" button, "Map Key" button and "Layer" button.

To follow the style of the website, all of them have the same visual as "Add a note to the map" button had.

Add a note to the map:
![Screenshot 2024-07-04 162504](https://github.com/openstreetmap/openstreetmap-website/assets/55288419/80ca05e8-8ccb-4008-92dc-f58c182b88f2)

Share:
![Screenshot 2024-07-04 162231](https://github.com/openstreetmap/openstreetmap-website/assets/55288419/a9af9c48-e9fb-4426-b310-01914ee2664e)

Map Key:
![Screenshot 2024-07-04 162203](https://github.com/openstreetmap/openstreetmap-website/assets/55288419/a987983b-76ff-437c-bfe9-ad936f9f3885)

Layer:
![Screenshot 2024-07-04 162153](https://github.com/openstreetmap/openstreetmap-website/assets/55288419/135ed0ee-9047-4580-afc9-397bdc3344ff)

When both "Add a note to the map" and "Share" are displayed, their visual is same as before:
![Screenshot 2024-07-04 162659](https://github.com/openstreetmap/openstreetmap-website/assets/55288419/0302e460-9bb4-4104-81ba-726cb340e727)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4949

-- Commit Summary --

  * Share button unusable on a cell phone

-- File Changes --

    M app/assets/javascripts/leaflet.share.js (3)
    M app/assets/javascripts/leaflet.sidebar.js (2)
    M app/assets/stylesheets/common.scss (4)
    M test/system/index_test.rb (35)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4949.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4949.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4949
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4949 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240704/0d13e337/attachment.htm>


More information about the rails-dev mailing list