[openstreetmap/openstreetmap-website] Order of comments in changeset comments feeds (PR #4944)

[David Tsiklauri]

@nertc commented on this pull request.



> @@ -46,6 +46,14 @@ def test_feed
         assert_select "item", :count => 3
       end
     end
+
+    # Gets comment Ids from HTML and checks that they are in descending order
+    last_comment_id = -1
+    @response.body.split("Changeset comment ")[1..].each_with_index do |data, index|

I changed the test to use parsed XML and HTML parser.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4944#discussion_r1666883827
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4944/review/2160852233 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240705/96b6a295/attachment.htm>