[openstreetmap/openstreetmap-website] Order of comments in changeset comments feeds (PR #4944)
Anton Khorev
notifications at github.com
Sat Jul 6 12:20:07 UTC 2024
@AntonKhorev commented on this pull request.
> @@ -46,6 +46,14 @@ def test_feed
assert_select "item", :count => 3
end
end
+
+ # Gets comment Ids from HTML and checks that they are in descending order
+ last_comment_id = -1
+ @response.body.split("Changeset comment ")[1..].each_with_index do |data, index|
This is the test I meant
https://github.com/openstreetmap/openstreetmap-website/blob/e3c919275818d46a515c183cf373d7a53bc6942a/test/controllers/traces_controller_test.rb#L729
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4944#discussion_r1667358873
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4944/review/2161524050 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240706/dd084022/attachment.htm>
More information about the rails-dev
mailing list