[openstreetmap/openstreetmap-website] Don't call check_signup_allowed inside save_new_user (PR #4960)

[Anton Khorev]

Users controller has a `save_new_user` method. Its entire body is wrapped by `if check_signup_allowed(current_user.email)`.

There's only one place where `save_new_user` is called. It's also wrapped by `if check_signup_allowed(current_user.email)`:

https://github.com/openstreetmap/openstreetmap-website/blob/e3c919275818d46a515c183cf373d7a53bc6942a/app/controllers/users_controller.rb#L90-L105

Why do we need to call `check_signup_allowed` both inside and outside of `save_new_user`?
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4960

-- Commit Summary --

  * Don't call check_signup_allowed inside save_new_user

-- File Changes --

    M app/controllers/users_controller.rb (54)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4960.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4960.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4960
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4960 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240706/769a51e0/attachment.htm>