[openstreetmap/openstreetmap-website] Move users list to administrator module (PR #4969)

Anton Khorev notifications at github.com
Tue Jul 9 16:57:25 UTC 2024


I wanted to rename `user_new_path`, it's standard name should be `new_user_path`. I tried using resourceful routes but we have `create` action mapped to `POST` `/user/new` which is also nonstandard. Then I'd have to do both `new` and `create` actions with resourceful routes and this will want to rewrite `users_path`. `users_path` is currently mapped to admin users list. I have to rename it first which is easier to do if I move it to a different module.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4969

-- Commit Summary --

  * Move users list to administrator module

-- File Changes --

    M .rubocop.yml (2)
    A app/controllers/administrator/users_controller.rb (35)
    M app/controllers/users_controller.rb (23)
    R app/views/administrator/users/_user.html.erb (4)
    R app/views/administrator/users/index.html.erb (8)
    M config/locales/en.yml (29)
    M config/routes.rb (6)
    A test/controllers/administrator/users_controller_test.rb (224)
    M test/controllers/users_controller_test.rb (215)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4969.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4969.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4969
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4969 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240709/25e5437b/attachment.htm>


More information about the rails-dev mailing list