[openstreetmap/openstreetmap-website] Update OpenID input label (PR #4971)

Anton Khorev notifications at github.com
Wed Jul 10 10:47:57 UTC 2024


- Get rid of html locale string `openid_html: "%{logo} OpenID"` just to prepend the logo image.
- Make the label read "OpenID URL", which includes removing the logo alt text inside the label. In this case the logo is just a visual cue, you don't want screen readers to read its alt text and then read the actual label. I added "URL" because it's present on [the livejournal login page](https://www.livejournal.com/identity/login.bml), where OpenID originated.

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/10b88bce-59c5-4d97-a90e-7d0690d139e2)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4971

-- Commit Summary --

  * Change OpenID input label to "OpenID URL"
  * Move OpenID logo out of locale string
  * Remove single-use OpenID logo helper
  * Remove alt text of OpenID logo inside input label

-- File Changes --

    M app/helpers/user_helper.rb (4)
    M app/views/application/_auth_providers.html.erb (5)
    M config/locales/en.yml (3)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4971.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4971.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4971
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4971 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240710/29ca98e9/attachment.htm>


More information about the rails-dev mailing list