[openstreetmap/openstreetmap-website] Show/hide entire OpenID form (PR #4977)

Anton Khorev notifications at github.com
Fri Jul 12 11:27:57 UTC 2024


When the login page is loaded, this form gets hidden by javascript:
![image](https://github.com/user-attachments/assets/15c43f62-fe6f-4585-9c53-7a46c2d060e2)

Later if the OpenID button is clicked, it gets shown.

Actually not quite. The form is always visible, what's getting shown/hidden are the div containing the url input and the *Continue* button. But there's not reason to show/hide them separately when you can show/hide the entire form.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4977

-- Commit Summary --

  * Show/hide entire OpenID form

-- File Changes --

    M app/assets/javascripts/auth_providers.js (6)
    M app/views/application/_auth_providers.html.erb (4)
    M test/system/user_signup_test.rb (12)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4977.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4977.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4977
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4977 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240712/ff957ddc/attachment.htm>


More information about the rails-dev mailing list