[openstreetmap/openstreetmap-website] Remove name argument from auth button helpers (PR #4995)
Anton Khorev
notifications at github.com
Tue Jul 16 14:18:50 UTC 2024
`auth_button` and `auth_button_preferred` helpers have the following first two arguments:
- `name`, which is an auth provider name
- `provider`, which is also an auth provider name, exactly the same
They used to be different [at some point](https://github.com/openstreetmap/openstreetmap-website/commit/e434cb154c5ccecd7fc0ce672e4de79bd9e7e06f), but not anymore. Now the calls look like `auth_button provider, provider`.
We can remove the `name` argument.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4995
-- Commit Summary --
* Remove name parameter from auth button helpers
-- File Changes --
M app/helpers/user_helper.rb (18)
M app/views/application/_auth_providers.html.erb (4)
M test/helpers/user_helper_test.rb (2)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4995.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4995.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4995
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4995 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240716/a7819ae2/attachment.htm>
More information about the rails-dev
mailing list