[openstreetmap/openstreetmap-website] Fixed displacing points specified from context menu (PR #4904)

[Anton Khorev]

@AntonKhorev commented on this pull request.



>      });
 
-    endpoint.setValue = function (value, latlng) {
+    endpoint.setValue = function (value, force_reverse_geocoding, latlng) {

There's no forcing of reverse geocoding. There's no code calling `reverse` like [here](https://github.com/openstreetmap/openstreetmap-website/blob/3debc151a86ed0016364d2d1348ecd82f5fa75fc/app/controllers/geocoder_controller.rb#L184). Nominatim will usually do reverse geocoding when "Directions from/to here" are selected, but that's because it decides on its own that the input query looks like coordinates. It won't make this decision correctly every time.

https://github.com/user-attachments/assets/4a12304d-e834-46f3-ae8f-4a6e147e5144


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4904#discussion_r1685826636
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4904/review/2190411858 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240721/a1bc4768/attachment.htm>