[openstreetmap/openstreetmap-website] NodeJS versions are out of sync again (Issue #5010)

[Andy Allan]

In #4992 the nodejs version was updated to node18, but only for Docker. The version wasn't updated for either the installation instructions (INSTALL.md), nor for the vagrant installation. These three alternatives should be kept in sync at all times.

The reason that nodejs had to be upgraded to version 18 was because eslint 9 requires it. The previous version of eslint, version 8, also ran on node 12, which is what is shipped on Ubuntu 22.04. https://github.com/openstreetmap/openstreetmap-website/commit/938037d6a26baecd334944957882c0108d2176e6 was the upgrade. This wasn't picked up as a breaking change in CI, since the "github flavoured ubuntu" used in CI doesn't use the Ubuntu node packages that INSTALL.md and vagrant use.

We need to do one of the following:
* Downgrade to eslint 8, and remove the external node18 installation from Docker, or
* Add the external node18 installation to both INSTALL.md and the vagrant configuration, or
* Set 24.04 as our minimum development version, update INSTALL.md, vagrant, Docker, other CI too

We also need to consider what extra things we can do to avoid this from happening again. For example,
* Is it possible to put maintainer-facing notes (or Dangerfile etc) to avoid these becoming out-of-sync?
* Is it possible to change github CI to use a fixed version of node, that we can match to the version that's shipped in Ubuntu?



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5010
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/5010 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240722/5a8f8b57/attachment.htm>