[openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)
Holger Jeromin
notifications at github.com
Wed Jul 24 22:50:28 UTC 2024
@HolgerJeromin commented on this pull request.
> @@ -86,6 +86,16 @@ OSM.initializeDataLayer = function (map) {
if (dataLoader) dataLoader.abort();
+ let spanLoading = $("#layers-data-loading");
+
+ if (!spanLoading.length) {
+ spanLoading = $("<span>")
+ .attr("id", "layers-data-loading")
+ .appendTo($("#label-layers-data"));
+
+ spanLoading.append(" " + I18n.t("javascripts.map.layers.loading"));
I am not sure if this "append" is safe in laguages which are written from right to left.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5009#pullrequestreview-2197911042
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5009/review/2197911042 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240724/e8d259ef/attachment.htm>
More information about the rails-dev
mailing list