[openstreetmap/openstreetmap-website] Map Data checkbox: perhaps use toggle slider instead (PR #5009)

David Tsiklauri notifications at github.com
Thu Jul 25 07:57:31 UTC 2024


@nertc commented on this pull request.



> @@ -86,6 +86,16 @@ OSM.initializeDataLayer = function (map) {
 
     if (dataLoader) dataLoader.abort();
 
+    let spanLoading = $("#layers-data-loading");
+
+    if (!spanLoading.length) {
+      spanLoading = $("<span>")
+        .attr("id", "layers-data-loading")
+        .appendTo($("#label-layers-data"));
+
+      spanLoading.append(" " + I18n.t("javascripts.map.layers.loading"));

@HolgerJeromin Interesting point. I've replaced a text with a spinner, so now it won't be a problem.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5009#discussion_r1691010233
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5009/review/2198594347 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240725/a2725fce/attachment.htm>


More information about the rails-dev mailing list