[openstreetmap/openstreetmap-website] Allow to edit revoked blocks (PR #5016)
Anton Khorev
notifications at github.com
Thu Jul 25 16:22:25 UTC 2024
@AntonKhorev commented on this pull request.
> + assert_redirected_to edit_user_block_path(block)
+ assert_equal "Only the moderators who created or revoked this block can edit it.", flash[:error]
+ block.reload
+ assert_not_predicate block, :active?
+ assert_equal "Original Reason", block.reason
+
+ session_for(creator_user)
+ check_block_updates(block)
+
+ session_for(revoker_user)
+ check_block_updates(block)
+ end
+
+ private
+
+ def check_block_updates(block)
Do you want to move only `check_block_updates` or every other such method too?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5016#discussion_r1691768867
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5016/review/2199804028 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240725/2dc6e5e3/attachment.htm>
More information about the rails-dev
mailing list