[openstreetmap/openstreetmap-website] Define fixed size for trace images (PR #5030)
Anton Khorev
notifications at github.com
Tue Jul 30 16:01:20 UTC 2024
@AntonKhorev commented on this pull request.
> @@ -2,4 +2,12 @@ module TraceHelper
def link_to_tag(tag)
link_to(tag, :tag => tag, :page => nil)
end
+
+ def trace_icon(trace, options = {})
+ options[:class] ||= "trace_image"
+ options[:alt] ||= ""
+
+ image_tag trace_icon_path(trace.user, trace),
+ options.merge(:width => 50, :height => 50)
```suggestion
options.merge(:size => 50)
```
`user_helper.rb` is partially using `:size`, I think we were moving towards it from `:width`/`:height` for square images.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5030#pullrequestreview-2208095725
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5030/review/2208095725 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240730/42b0a875/attachment.htm>
More information about the rails-dev
mailing list