[openstreetmap/openstreetmap-website] Larger font size in search form, svg icon for "Go" button (PR #4866)

Anton Khorev notifications at github.com
Sat Jun 1 05:02:41 UTC 2024


Should fix #1414 according to https://github.com/openstreetmap/openstreetmap-website/issues/1414#issuecomment-2130065798. I can't test it without an iPhone.

Changed small form controls to default ones. This makes font size to be 16px.

But there's another obstacle: the *Go* button. "Go" is short enough in English, but how about other languages. With a larger font it may get too large. To avoid that I replaced "Go" with a magnifying glass icon.

Before/after in English:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/426f8d7d-cb1a-46aa-b451-3f483675af03)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/3a63b3ad-2eed-4ea3-a90b-ee092ad75491)

Before/after in Bulgarian (wider labels):
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/cbfdd444-d583-44d4-97d4-1807ef0a310e)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/bf7d983d-6bd6-43ab-bf53-4b0e7820defa)

Before/after in Polish (already trying to replace "Go" with a symbol):
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/15e427df-2985-48e3-9af0-be2b8fa16bfe)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/099eae3e-71ef-4475-994e-b1089ea34b43)

200% zoom:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/7cc3cfca-d920-467e-9f46-135e9213e4ed)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4866

-- Commit Summary --

  * Replace search button text with svg icon
  * Increase font size in search form

-- File Changes --

    M app/views/layouts/_search.html.erb (19)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4866.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4866.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4866
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4866 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240531/e40a1005/attachment-0001.htm>


More information about the rails-dev mailing list