[openstreetmap/openstreetmap-website] Post-merge UI review for #4455 (Issue #4773)
Andy Allan
notifications at github.com
Sat Jun 1 06:55:01 UTC 2024
> Would addressing
>
> > Raw html input used for password field
>
> address #4543 ?
No, those are unrelated. This item is about what is written in the erb template, not what is outputted in the final rendered html. Specifically, the mentioned commit did something along the lines of:
```diff
- <%= f.password_field :password, :label => t(".password"), :tabindex => 2, :value => "", .....
+ <input class="form-control mb-3" type="password" name="password" id="password" .....
```
i.e. swapped from using a rails form builder, and instead used raw html. Both approaches still output the same html `<input type="password" ...>` field.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4773#issuecomment-2143330535
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/issues/4773/2143330535 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240531/0794be0a/attachment.htm>
More information about the rails-dev
mailing list