[openstreetmap/openstreetmap-website] Use button elements that allow word wrap for note controls (PR #4871)

Anton Khorev notifications at github.com
Mon Jun 3 10:53:52 UTC 2024


To make sure that #1353 is not a problem even on very narrow screens. `<button>` allows word wrap inside; if you need several words for example for "comment and close", they'll still fit on screen as long as every individual word fits.

Changesets already use `<button>` in discussion forms.

Before:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/f02047bd-55fe-4b38-b577-329ad4eaaed3)

After:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/8ca31d78-197d-4661-99e2-cef7b205f03e)


You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4871

-- Commit Summary --

  * Use button elements that allow word wrap for note controls

-- File Changes --

    M app/assets/javascripts/index/note.js (10)
    M app/views/notes/show.html.erb (10)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4871.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4871.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4871
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4871 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240603/5b8edb90/attachment-0001.htm>


More information about the rails-dev mailing list