[openstreetmap/openstreetmap-website] Use button elements that allow word wrap for note controls (PR #4871)
Tobias
notifications at github.com
Tue Jun 4 06:40:28 UTC 2024
Looking into this a bit…
In https://github.com/openstreetmap/openstreetmap-website/pull/4871/files#diff-8f18485b763264500054435af432745e2a51b4402140728dc4df89024768b71bL48 we take the ajax type from the event. But it looks like we expect a specific type, so maybe we should hard code it here?
The other thing would be to make it explicit that the button is a submit button with "type=submit" which is what the Bootstrap docs use in their form example: https://getbootstrap.com/docs/5.3/forms/overview/#overview
However, https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button?retiredLocale=de#type does not go into details on this. So maybe https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button?retiredLocale=de#formmethod is more what we need…
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4871#issuecomment-2146727816
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4871/c2146727816 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240603/475fa727/attachment.htm>
More information about the rails-dev
mailing list