[openstreetmap/openstreetmap-website] Remove javascripts.changesets locale strings (PR #4878)

Anton Khorev notifications at github.com
Tue Jun 4 13:39:35 UTC 2024


They are used not in javascript but rather in .html.erb templates.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4878

-- Commit Summary --

  * Move show/hide changeset comment locale strings out of javascripts
  * Write changeset comment button using tag.button
  * Move comment changeset locale string out of javascripts
  * Write changeset subscribe/unsubscribe buttons using tag.button
  * Move changeset subscribe/unsubscribe locale strings out of javascripts

-- File Changes --

    M app/views/changesets/show.html.erb (21)
    M app/views/diary_entries/show.html.erb (4)
    M config/locales/en.yml (14)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4878.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4878.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4878
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4878 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240604/ad605a7a/attachment-0001.htm>


More information about the rails-dev mailing list