[openstreetmap/openstreetmap-website] Write directions sidebar header using .erb template (PR #4900)

Anton Khorev notifications at github.com
Sat Jun 15 00:16:33 UTC 2024


Other sidebar pages have at least a heading and some placeholder in their `.html.erb` template, for example [geocoder search](https://github.com/openstreetmap/openstreetmap-website/blob/84aa7f455ae58b4b051368e35dbc43f780b3aa0f/app/views/geocoder/search.html.erb). Directions search is the exception, it's template is [essentially empty](https://github.com/openstreetmap/openstreetmap-website/blob/84aa7f455ae58b4b051368e35dbc43f780b3aa0f/app/views/directions/search.html.erb). Instead everything is written by `directions.js`.

Here I'm moving the directions heading to `.html.erb`. Actually I'm doing this to add more things to `.html.erb` later.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4900

-- Commit Summary --

  * Write directions sidebar header using .erb template

-- File Changes --

    M app/assets/javascripts/index/directions.js (52)
    M app/views/directions/search.html.erb (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4900.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4900.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4900
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4900 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240614/ec4fd7f1/attachment.htm>


More information about the rails-dev mailing list