[openstreetmap/openstreetmap-website] Fully encode wikipedia tag values (PR #4887)
Andy Allan
notifications at github.com
Wed Jun 19 15:58:22 UTC 2024
Sorry, perhaps I wasn't clear. My suggestion is to avoid converting spaces to underscores, but of course any underscores already used in the tag would be preserved.
```
irb(main):001> require 'erb'
=> true
irb(main):002> ERB::Util.url_encode('Leisure_and_entertainment')
=> "Leisure_and_entertainment"
```
So if a mapper added spaces in the ids, that's their mistake, because there's no spaces in the ids. If they used underscores, those would be preserved.
What I think we should avoid is *converting* spaces into underscores, because it's unnecessary.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4887#issuecomment-2179037642
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4887/c2179037642 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240619/2b7b47e9/attachment.htm>
More information about the rails-dev
mailing list