[openstreetmap/openstreetmap-website] Fully encode wikipedia tag values (PR #4887)

[Andy Allan]

> Spaces after `#` seem to be more prevalent than underscores in osm data.

Ah, interesting, I wasn't aware that we were doing that for the fragments deliberately. Thanks for pointing that out.

It feels to me like it's the wrong thing to do, since the spaces are completely invalid in mediawiki fragments, and therefore they are invalid data when used in an OSM tag too. Tracing it back, it seems like in [May 2015](https://github.com/openstreetmap/openstreetmap-website/issues/967) other data consumers were already silently fixing the broken fragment data, and so the same automatic fixup was also applied to this codebase too. Unfortunately it means that every other consumer of OSM data will need to do the same too! Oh well.

So we would need to keep the `tr` for the fragments, but for the page name itself, it's still unnecessary. But overall I still stand by my earlier comment that's it's not the most important thing for us to deal with.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4887#issuecomment-2179318349
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4887/c2179318349 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240619/c908a3b0/attachment.htm>