[openstreetmap/openstreetmap-website] Add pull request template (PR #4919)

Tobias notifications at github.com
Sun Jun 23 04:25:54 UTC 2024


@tordans commented on this pull request.

I think this is a good template that will make thinks better for some PRs. I certainly does not harm the process, because one can always remove all this very easily when creating a PR that does not fit this schema.

I would also remove the risk section. And make the intro even more explicit on the PR section which is where all the "do squash, do rebase, no merge commits" part is written.

> @@ -0,0 +1,10 @@
+<!--Please read the contributing guidelines before making a PR: https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md-->

```suggestion
<!-- 
Please read the contributing guidelines before making a PR: 
  https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md

Especially the section on how to present PRs:
  https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#pull-requests
-->
```

> +
+### Risks
+<!--Is this a low, medium, or high risk change? Explain why.-->

```suggestion
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4919#pullrequestreview-2134062525
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4919/review/2134062525 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240622/d4291d43/attachment.htm>


More information about the rails-dev mailing list