[openstreetmap/openstreetmap-website] Fixed displacing points specified from context menu (PR #4904)
Anton Khorev
notifications at github.com
Mon Jun 24 13:39:41 UTC 2024
> so it doesn't perform unnecessary geocoding anymore for the previously selected point (either source or destination), when entering second point
Doesn't it still do unnecessary geocoding for the first point? And then its marker may get shifted as a result of this geocoding.
What an endpoint should do is to detect that it has coordinates as a value and don't try to query nominatim if it does. Search has server-side regexps to detect coordinates:
https://github.com/openstreetmap/openstreetmap-website/blob/7cd900eca0af0f2eaeb54360ec8d1b9153434455/app/controllers/geocoder_controller.rb#L196
Here something simpler might suffice like *number, number* format without all those degree signs, N/S/E/W letters etc.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4904#issuecomment-2186609047
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4904/c2186609047 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240624/27f88f8f/attachment.htm>
More information about the rails-dev
mailing list