[openstreetmap/openstreetmap-website] Replace sign up, terms and confirmation illustrations with SVG (PR #4793)

Anton Khorev notifications at github.com
Mon Jun 24 14:09:43 UTC 2024


@AntonKhorev requested changes on this pull request.



> @@ -722,16 +722,15 @@ tr.turn {
   bottom: 0;
 
   &.new-user-main {
-    background-image: image-url("sign-up-illustration.png");
-    background-position-x: 50px;

It's probably better to reproduce this background position for now, which is going to be `background-position-x: 70px;`

I don't know how to make it not to overlap with the tabs when their size is unknown using background-position alone. That's why I suggested using a flex container but that's for another pull request.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4793#pullrequestreview-2134297871
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4793/review/2134297871 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240624/884ee04b/attachment.htm>


More information about the rails-dev mailing list