[openstreetmap/openstreetmap-website] Home Location page (PR #4926)

Anton Khorev notifications at github.com
Thu Jun 27 03:02:47 UTC 2024


This adds a home location page with its own URL similar to what's suggested in https://github.com/openstreetmap/openstreetmap-website/issues/670#issuecomment-31867047, without sidebar and extra controls. Instead of `/:username/home` I use the path `/account/home` because it's easier to implement, no need to check `:username`.

A link to this page is available on every other page with the user dropdown menu. This fixes #1810.

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/fe4a4e8e-9931-4946-9e36-0e15acbfa6ab)

It's possible to leave this page for another map page. In this case the javascript controller removes the home location marker. This fixes #669 and #670.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4926

-- Commit Summary --

  * Add empty account home page
  * Show/hide marker in account home js controller
  * Add "Go to Home Location" to every page, link it to account home page
  * Show alert on account home page if home location is not set

-- File Changes --

    M app/abilities/ability.rb (2)
    M app/assets/javascripts/index.js (14)
    A app/assets/javascripts/index/home.js (38)
    A app/controllers/account/homes_controller.rb (13)
    A app/views/account/homes/show.html.erb (1)
    M app/views/layouts/_header.html.erb (4)
    M app/views/layouts/map.html.erb (12)
    M config/locales/en.yml (3)
    M config/routes.rb (1)
    A test/system/account_home_test.rb (57)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4926.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4926.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4926
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4926 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240626/b503f172/attachment.htm>


More information about the rails-dev mailing list