[openstreetmap/openstreetmap-website] Browse node coordinates (PR #4930)

Anton Khorev notifications at github.com
Fri Jun 28 02:57:33 UTC 2024


It's now possible to see node locations on node version pages for visible versions:

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/77d8daad-5068-41d9-825f-58d394497344)
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/c86a8762-3b55-45c6-ae9c-618ac1d7a0b1)

Also no extra api requests to fetch node coordinates for map markers:

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/59f63d84-73e6-4630-a4e4-c772fd2851e9) ![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/eb8298f7-6d97-490e-9943-0877a3a18fa2)
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4930

-- Commit Summary --

  * Add details div to element pages
  * Add visible node coordinates to details div
  * Add coordinates to map object if available
  * Refactor making map object layer
  * Use node coordinates instead of api request if possible
  * Show locations of old node versions

-- File Changes --

    M app/assets/javascripts/index.js (42)
    M app/assets/javascripts/leaflet.map.js (109)
    M app/views/browse/_common_details.html.erb (40)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4930.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4930.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4930
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4930 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240627/f0d4a524/attachment.htm>


More information about the rails-dev mailing list