[openstreetmap/openstreetmap-website] Avoid using partial rendering in /map.json (PR #4141)

mmd notifications at github.com
Fri Jun 28 18:25:19 UTC 2024


Some sites like https://scoutapm.com/blog/performance-impact-of-using-ruby-on-rails-view-partials seem to suggest that calling partials in a loop isn't the best idea. Alternative option might be to pass a collection to the partial instead (which happens to avoid the DRY issue mentioned earlier).

I can create a PR if this commit is of interest: https://github.com/mmd-osm/openstreetmap-website/commit/8c20bc1d98156af2501c9c4ec324473dc72a0994

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4141#issuecomment-2197430449
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4141/c2197430449 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240628/3e23aa1e/attachment-0001.htm>


More information about the rails-dev mailing list